Return to previous page

Left Inline Breadcrumbs missing Delimiter on second level

This topic has 6 replies, 3 voices, and was last updated 6 years, 10 months ago ago by Rose Tyler

thisisbolo

Participant

January 13, 2018 at 03:25
The second+ level delimiter is missing on ‘pages’ (non-shop) of any breadcrumbs with with left inline style. This is only affecting pages and not woocommerce single product pages.

First Level (this works fine)

Home > Sample Page

Second Level (this is busted)

Home > Sample Page Another Sample Page

This should render as so

Home > Sample Page > Another Sample Page

I’ve managed to tuck this in with CSS (for a quick fix) but we’ll need to update template-elements.php

I was messing around and think this does the trick but I’ll leave it to the dev theme to deploy a fix

this is line 1140 – 1146 in template-elements.php
```
        } elseif ( is_page() && $post->post_parent ) {
          $parent_id  = $post->post_parent;
          $breadcrumbs = array();
          while ($parent_id) {
            $page = get_page($parent_id);
            $breadcrumbs[] = '<a href="' . get_permalink($page->ID) . '">' . get_the_title($page->ID) . '</a>' . $delimiter;
            $parent_id  = $page->post_parent;
          }
```
I added in $delimiter after ‘‘.

It makes sense to NOT HAVE the delimiter in Center and Left Align but for Left inline it should.

I tested this on a barebones fresh install to make sure it’s just not me but maybe it is. Rose, Olga, can you test on your end. Do the following for page structure then change the page breadcrumb to left inline

Home Page
– Sample Page
– Another Sample Page

Hope this is thorough enough. Thanks!
#181768 Copied Theme version: I don't even have this theme (just kidding, seriously!) WooCommerce version: -5.0 (just kidding)
5 Answers

thisisbolo

Participant

January 13, 2018 at 03:30

For anyone who wants to cheat this with CSS you could do the following but I’d target your CSS by page ID cuz the delimiter sticks to single tiered pages and that’s bugs me, might not bug you but it sure does bug me > and bugs me > and bugs me even more > hanging delimiters > for no reason > you know? > :p >

.bc-type-left2 .title::before {content:"\f105"; font-family: FontAwesome; font-weight: 300; padding: 0px 2px;}

#181769 Copied

thisisbolo

Participant

January 14, 2018 at 22:21

Just a suggestion, the left inline breadcrumbs should also render as a none headline. Anyone who’d purpose this would most likely add their own h1 tag. Having two on a page would kill any efforts for SEO.

#181804 Copied

Olga Barlow

Support staff

January 15, 2018 at 17:18

Hello,

Yes, we checked the subpages and found this bug. It will be fixed in next theme update.

Regards

#181947 Copied

thisisbolo

Participant

January 19, 2018 at 06:27

Thank you for fixing this in the latest release. And thanks for the many other fixes and updates in the latest code release. You’ve been very supportive on this board!

#182298 Copied

Rose Tyler

Support staff

January 19, 2018 at 11:02

Hello,

Thank you for your thoughts! We deeply appreciate it 🙂
Have a nice day.

Regards

#182340 Copied
Tagged: breadcrumbs, delimiter, themes, woocommerce, wordpress
Viewing 6 results - 1 through 6 (of 6 total)